Talk About Quality

Tom Harris

Code Review Starter Kit

with 3 comments

Starting to review your code? Want that 10-to-1 payback for finding problems early, while they’re easier to fix, but concerned about the time investment?

Whatever the method, here’s what effective code reviews have in common:

  • Everyone knows which code to review
  • Reviewers are familiar with requirements and design
  • Purpose of review is clear
  • Reviewers review all the code by themselves first
  • Reviewers record comments in writing
  • Code author hears and accepts comments in person
  • Code author tracks comments through to fix
  • Everyone saves time-stamped records to see how they’re doing

Yes, there’s more to it than that, but don’t start with less.


Written by Tom Harris

September 13, 2006 at 5:37 pm

Posted in Code Review

3 Responses

Subscribe to comments with RSS.

  1. […] « Code Review Starter Kit […]

  2. […] But then I start asking questions. I admit I have an opinion in mind. Some minimal attributes of code review. But listening means asking my question and then keeping quiet, so I do. I ask, are the issues recorded? (Yes? Can I see them? No? Why not?) […]

    It « Talk About Quality

    October 4, 2006 at 12:37 am

  3. […] Code Review Starter Kit 에 있는 […]

Leave a Reply

Fill in your details below or click an icon to log in: Logo

You are commenting using your account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s